Polygon box transform op for OCR East detection. #10802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
May 22, 2018
| class QuadTransformOpMaker : public framework::OpProtoAndCheckerMaker { | ||
| public: | ||
| void Make() override { | ||
| AddInput("Input", "The input with shape [batch_size, 8, height, width]"); |
There was a problem hiding this comment.
Maybe the shape can be more general, do not fix to 8.
| namespace paddle { | ||
| namespace operators { | ||
|
|
||
| #define GEO_CHANNEL 8 |
There was a problem hiding this comment.
The code in .h can be moved to .cc and .h can be removed.
qingqing01
reviewed
May 25, 2018
| places.append(core.CUDAPlace(0)) | ||
| # if core.is_compiled_with_cuda() and core.op_support_gpu(self.op_type): | ||
|
|
||
| # places.append(core.CUDAPlace(0)) |
There was a problem hiding this comment.
Need to resume the code.
| using Tensor = framework::Tensor; | ||
|
|
||
| template <typename DeviceContext, typename T> | ||
| class BoxRestoreCPUKernel : public framework::OpKernel<T> { |
There was a problem hiding this comment.
Maybe the name can call:
PolygonBoxTransform ?
1. rename op 2. uncomment unitest on GPU
qingqing01
approved these changes
May 26, 2018
qingqing01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: EAST: An Efficient and Accurate Scene Text Detector